From c869bb09538fa3c7d35d238f4a6cf4a724f994ab Mon Sep 17 00:00:00 2001 From: tkmxqrdxddd Date: Tue, 17 Mar 2026 20:29:13 +0100 Subject: [PATCH] fix: update release workflows to use artifacts and proper triggers - Change release.yml to trigger on tag push instead of release event - Remove problematic release upload from ci-cd.yml - Use upload-artifact instead for package artifacts --- .github/workflows/ci-cd.yml | 9 ++++----- .github/workflows/release.yml | 18 +++++++++++++----- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index dd0640f..2b6bee9 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -153,9 +153,8 @@ jobs: run: | dpkg-deb --build debian davinci-video-converter_${GITHUB_REF#refs/tags/}_${{ matrix.arch }}.deb - - name: Upload to Release - uses: softprops/action-gh-release@v1 + - name: Upload DEB package as artifact + uses: actions/upload-artifact@v4 with: - files: davinci-video-converter_*.deb - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + name: davinci-video-converter-${{ matrix.arch }}.deb + path: davinci-video-converter_*.deb diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 98e8450..dd73344 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,8 +1,9 @@ name: Release Pipeline on: - release: - types: [published, created] + push: + tags: + - 'v*' jobs: release: @@ -73,9 +74,16 @@ jobs: run: | dpkg-deb --build debian davinci-video-converter_${GITHUB_REF#refs/tags/}_${{ matrix.arch }}.deb - - name: Upload to Release + - name: Upload DEB package as artifact + uses: actions/upload-artifact@v4 + with: + name: davinci-video-converter-${{ matrix.arch }}.deb + path: davinci-video-converter_*.deb + + - name: Create Release uses: softprops/action-gh-release@v1 with: files: davinci-video-converter_*.deb - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + token: ${{ secrets.GITHUB_TOKEN }} + draft: false + prerelease: false